Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override RLP decoders with ones from plugins; fix op decoder #6969

Merged
merged 18 commits into from
May 21, 2024
Merged

Override RLP decoders with ones from plugins; fix op decoder #6969

merged 18 commits into from
May 21, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented May 2, 2024 •
edited

Changes

  • Register plugin decoders, allowing to override existing ones
  • Add keyed decoders, means in addition to type a string key can be used to retrieve and encoder
  • Fix sync trace logs a bit

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Remarks

We need to do the same for tx receipt storage, I guess. But maybe later

@benaadams
Copy link
Member

Haha, didn't see was draft :)

@flcl42 flcl42 requested a review from asdacap May 2, 2024 12:06
@flcl42 flcl42 marked this pull request as ready for review May 6, 2024 08:59
@flcl42 flcl42 marked this pull request as draft May 6, 2024 11:57
@flcl42 flcl42 marked this pull request as ready for review May 8, 2024 14:30
@flcl42 flcl42 marked this pull request as draft May 8, 2024 14:37
@flcl42 flcl42 marked this pull request as ready for review May 8, 2024 16:00
LukaszRozmej
LukaszRozmej reviewed May 10, 2024
View reviewed changes
src/Nethermind/Nethermind.Api/Extensions/IPlugin.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Blockchain/Receipts/ReceiptsRootCalculator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Proof/ProofRpcModule.cs Outdated Show resolved Hide resolved
...Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V63/Messages/ReceiptsMessageSerializer.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Optimism.Plugin.Test/ReceiptDecoderTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/ReceiptArrayStorageDecoder.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/Rlp.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/Rlp.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/RlpBehaviors.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloadContext.cs Outdated Show resolved Hide resolved
@flcl42 flcl42 requested review from rubo and a team as code owners May 13, 2024 08:54
LukaszRozmej
LukaszRozmej approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have someone from optimism stack review it too.

...ethermind/Nethermind.AccountAbstraction.Test/Network/UserOperationsMessageSerializerTests.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Optimism.Test/ReceiptDecoderTests.cs Outdated Show resolved Hide resolved
@flcl42 flcl42 requested a review from alexb5dh May 14, 2024 13:05
@flcl42
Copy link
Contributor Author

flcl42 commented May 14, 2024

Would be good to have someone from optimism stack review it too.

It's done according to what a learned from @protolambda's answers

@flcl42 flcl42 merged commit b37bb95 into master May 21, 2024
68 checks passed
@flcl42 flcl42 deleted the receipt-decoder-di branch May 21, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@jmederosalvarado jmederosalvarado jmederosalvarado approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@benaadams benaadams Awaiting requested review from benaadams

@deffrian deffrian Awaiting requested review from deffrian

@rubo rubo Awaiting requested review from rubo rubo is a code owner

@alexb5dh alexb5dh Awaiting requested review from alexb5dh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@flcl42 @benaadams @alexb5dh @LukaszRozmej @jmederosalvarado