Refactor/separate block production and running #7012
Conversation
| event EventHandler<BlockEventArgs> BlockProduced; | ||
| Task<Block?> BuildBlock( | ||
| BlockHeader? parentHeader = null, | ||
| CancellationToken? cancellationToken = null, |
There was a problem hiding this comment.
minor: convention puts cancellationToken often as last parameter to separate it from more logic-oriented parameters.
| Task Start(); | ||
| Task StopAsync(); |
There was a problem hiding this comment.
We don't have truly async implementations of this?
There was a problem hiding this comment.
Only clique for stop
| using Nethermind.Evm.Tracing; | ||
|
|
||
| namespace Nethermind.Consensus.Producers | ||
| { | ||
| public interface IBlockProducerInfo | ||
| { | ||
| IBlockProducer BlockProducer { get; } | ||
| IManualBlockProductionTrigger BlockProductionTrigger { get; } | ||
| Func<BlockHeader, bool> Condition { get; } |
There was a problem hiding this comment.
Switched to custom interface.
|
Yea, it does not look like it help much unfortunately. It does expose |
| @@ -9,7 +9,7 @@ namespace Nethermind.Consensus; | |||
|
|
|||
| public interface IBlockProducerRunner | |||
| { | |||
| Task Start(); | |||
| void Start(); | |||
There was a problem hiding this comment.
or we could make it a ValueTask if we wanted flexibility
evm_minewhich may want to trigger event which is used to put the block in main chain.Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Nodes on testing