Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynimic qrcode to display and scan #4604

Merged
merged 16 commits into from
May 21, 2024
Merged

feat: add dynimic qrcode to display and scan #4604

merged 16 commits into from
May 21, 2024

Conversation

hellohublot
Copy link
Contributor

No description provided.

Copy link

codesandbox bot commented May 17, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

what-the-diff bot commented May 17, 2024

PR Summary

  • Introduction of new dependency
    Added "@ngraveio/bc-ur" as a new part of project dependencies.
  • Enhancements in QR code generation
    Upgraded QR code creation process to use new partValue concept.
  • Improvement in QR code parsing functionality
    Incorporated changes to handle and decode new animation QR codes format.
  • QR code data structure revamp
    Updated the data structure used for QR codes to accommodate multi-part QR codes.
  • Advancements in Scan QR code view
    Enhanced the Scan QR code view to manage new, dynamic QR code format.
  • Augmentation of unit tests
    New test cases added to make sure the new QR code changes are working as expected.

This comment was marked as off-topic.

Copy link

socket-security bot commented May 17, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@huhuanming huhuanming marked this pull request as ready for review May 20, 2024 01:03
@huhuanming huhuanming enabled auto-merge (squash) May 20, 2024 01:03
@huhuanming
Copy link
Contributor

@SocketSecurity ignore npm/protobufjs@6.11.4
@SocketSecurity ignore npm/web3@1.10.4
@SocketSecurity ignore npm/biginteger@1.0.3
@SocketSecurity ignore npm/core-js-pure@3.37.1

huhuanming
huhuanming previously approved these changes May 20, 2024
originalix
originalix previously approved these changes May 21, 2024
@originalix
Copy link
Contributor

处理下冲突哦

@huhuanming huhuanming dismissed stale reviews from originalix and themself via e7853c5 May 21, 2024 01:26
@huhuanming
Copy link
Contributor

冲突解决了

@huhuanming huhuanming merged commit ba09553 into x May 21, 2024
4 checks passed
@huhuanming huhuanming deleted the dynimicQRCode branch May 21, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants