Curve Swap Implementation #225
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanHiden
reviewed
Apr 2, 2022
| ); | ||
|
|
||
| if ( | ||
| returnToSenderAddress != _thisAddress && |
There was a problem hiding this comment.
why not use address(this);
RomanHiden
reviewed
Apr 2, 2022
| function setSwapApprovals(address[] memory tokens) public { | ||
| address curveRoute = curveAddressProvider.get_address(2); | ||
| for (uint256 i = 0; i < tokens.length; i++) { | ||
| IERC20(tokens[i]).safeApprove(curveRoute, 0); |
There was a problem hiding this comment.
safeApprove handles zero case
RomanHiden
reviewed
Apr 2, 2022
| onlyOwner | ||
| { | ||
| for(uint i=0;i<tokens.length;++i){ | ||
| IERC20(tokens[i]).safeApprove(spender,0); |
There was a problem hiding this comment.
safeApprove handles zero case
|
rebase this to itoken-collateral, we might wanna merge it before we deploy itoken-collateral. since ProtocolSettings is changed |
RomanHiden
reviewed
Aug 26, 2022
| function exchange(address pool, address from, address to, uint256 amount, uint256 minRecv, address receiver) external returns(uint256); | ||
| } | ||
|
|
||
| interface ICurveProvider { |
There was a problem hiding this comment.
generally I prefer interface per file
|
this needs to be rebased to itoken-collateral. what do we need to do to include this in arbitrum deployment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.