Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toFloat filter in [Assert] #2772

Merged
merged 5 commits into from
May 15, 2024

Conversation

chengyu2000311
Copy link
Contributor

@chengyu2000311 chengyu2000311 commented May 10, 2024

add toFloat filter in [Assert]
Issues: #1732

@chengyu2000311 chengyu2000311 force-pushed the toFloat branch 2 times, most recently from dad1b1d to 221bdf3 Compare May 12, 2024 20:30
@fabricereix
Copy link
Collaborator

Hi @chengyu2000311,
thanks for your PR.
Just one small remark for the code, the filters should be sorted alphabetically, thus toFloat should appear before toInt.
I also let you fix the failing steps in the checks. Let us know if you need help.

@chengyu2000311 chengyu2000311 force-pushed the toFloat branch 2 times, most recently from dbb3ae9 to 6c36085 Compare May 14, 2024 14:51
@chengyu2000311
Copy link
Contributor Author

hey @fabricereix , thanks for the comment, I modified accordingly and also solved the error in integ test :)

@chengyu2000311
Copy link
Contributor Author

Hey @fabricereix , sorry but I just removed the unnecessary space in filter.json to pass the CI

@chengyu2000311
Copy link
Contributor Author

Hey @jcamiel , I fixed the format issue in filter.html

@fabricereix
Copy link
Collaborator

/accept

@hurl-bot
Copy link
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Collaborator

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, chengyu2000311/hurl/toFloat now embeds these commits:

  • ec9af97 Update binary installation.
  • 9ec4d06 Fix installation instruction with precompiled binaries on Linux
  • 42dea4c Add proxy option documentation
  • 1d9117c Add description in streaming test
  • 5e92ed9 Add optional directory argument to HurlResult::to_json method.
  • 2a2c50a Add test streaming
  • 83c0f43 Fix missing semi-colons.
  • 8973f17 Fix path on Windows npm install.

@hurl-bot
Copy link
Collaborator

🕗 /accept is still running, please wait for completion.

@hurl-bot
Copy link
Collaborator

✅ Pull request merged and closed by fabricereix with fast forward merge..

# List of commits merged from chengyu2000311/hurl/toFloat branch into Orange-OpenSource/hurl/master branch:

@hurl-bot hurl-bot closed this May 15, 2024
@hurl-bot hurl-bot merged commit db2d535 into Orange-OpenSource:master May 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants