Add support for sending and recieving large json arrays. #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses IAsyncEnumerables and a custom Http Content to send large json arrays. Uses IAsyncEnumerator to recieve large json arrays. Correctly handles memory safety and IDisposables.
|
@RicoSuter When will this be merged to support streaming? |
This seems unlikely to be merged, kind of a niche use case I think? There's some workarounds that are posted on the issue pages. Happy to follow up on this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports large json arrays that may not fit in memory and cause out of memory exceptions.
Uses IAsyncEnumerable and a custom Http Content to send large json arrays.
Uses IAsyncEnumerator to recieve large json arrays.
By returning an IAsyncEnumerator it correctly handles memory safety and IDisposables.
Possible fix for
#4236 and #3909
Note: I'm like 95% confident about the implementation for reading large json arrays. I'm much less confident about the custom httpContent for sending large arrays being the best approach.