LibJS+LibCore: Some BSD Compatibility updates #24273
Merged
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
ADKaster
changed the title
|
Correction: FreeBSD 14 and above do have |
ADKaster
force-pushed
the
mmap-fd
branch
2 times, most recently
from
32e794a
to
f810c77
Compare
NetBSD and FreeBSD get upset when we don't set the fd to an invalid value when using a non-shared mapping. Reported-By: Thomas Klausner <wiz@gatalith.at>
FreeBSD and NetBSD don't have secure_getenv(3), same as macOS. FreeBSD 13 and lower also don't allow setting environ pointers to null. Co-Authored-By: Robert Clausecker <fuz@FreeBSD.org>
We were already linking librt to LibCore for shm_open and friends. Now that we build the code that uses POSIX shm into LibCoreMinimal, we need to link librt into that as well.
On some C libraries, like NetBSD and musl-libc, this under-specified edge case results in a crash rather than silently ignoring the null pointer.
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetBSD and FreeBSD get upset when we don't set the fd to an invalid
value when using a non-shared mapping.
FreeBSD and NetBSD don't have secure_getenv(3), same as macOS.
FreeBSD 13 and lower also don't allow setting environ pointers to null.
Ref: #23375
cc @0-wiz-0
cc @clausecker