Utilities: Support reading arbitrarily long lines #24311
+45
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
approved these changes
May 28, 2024
| @@ -711,8 +715,7 @@ class File { | |||
| OwnPtr<FileSystem::TempFile> m_output_temp_file; | |||
| size_t m_line_number { 0 }; | |||
| ByteString m_current_line; | |||
| constexpr static size_t MAX_SUPPORTED_LINE_SIZE = 4096; | |||
| Array<u8, MAX_SUPPORTED_LINE_SIZE> m_buffer; | |||
| OwnPtr<ByteBuffer> m_buffer; | |||
Comment on lines
+671
to
+672
| m_buffer = make<ByteBuffer>(); | ||
| TRY(m_buffer->try_resize(PAGE_SIZE)); |
There was a problem hiding this comment.
Then this can be a create_uninitialized()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading arbitrarily long lines in the
comm,cut,grepandsedutilities.Previously, these utilities wouldn't behave correctly when working with input containing lines longer than 4KiB.
I've also included a drive-by commit to fix an off-by-one error in
cut, which led to the last character on each line being skipped when the-bor-coption was used.