Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chess: Add display widget for moves #24373

Merged
merged 1 commit into from
May 23, 2024

Conversation

d-gaston
Copy link
Contributor

@d-gaston d-gaston commented May 19, 2024

Adds a TextEditor widget to the chess application to display move
history. It is updated whenever Board::apply_move is called to reflect
the current board state.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 19, 2024
Copy link
Member

@LucasChollet LucasChollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you set your editor to use 72-characters line wrap instead of 52?
From CONTRIBUTING.md:

Wrap your commit messages at 72 characters.

Userland/Games/Chess/ChessWidget.cpp Outdated Show resolved Hide resolved
Copy link
Member

@LucasChollet LucasChollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucasChollet LucasChollet added ✅ pr-community-approved PR has been approved by a community member and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels May 19, 2024
@LucasChollet
Copy link
Member

(If you want to do something about the manual centering code that is all over the place, feel free to open a PR :yakbait:)

@github-actions github-actions bot added 👀 pr-needs-review PR needs review from a maintainer or community member and removed ✅ pr-community-approved PR has been approved by a community member labels May 19, 2024
Adds a TextEditor widget to the chess application to display move
history. It is updated whenever Board::apply_move is called to reflect
the current board state.
@nico nico added ✅ pr-community-approved PR has been approved by a community member and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels May 22, 2024
@ADKaster ADKaster merged commit 2d5cb1e into SerenityOS:master May 23, 2024
11 checks passed
@github-actions github-actions bot removed the ✅ pr-community-approved PR has been approved by a community member label May 23, 2024
@d-gaston d-gaston deleted the chess-move-display-widget branch May 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants