Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix verion typo #2050

Merged
merged 1 commit into from
May 30, 2024
Merged

fix verion typo #2050

merged 1 commit into from
May 30, 2024

Conversation

dvnrsn
Copy link
Contributor

@dvnrsn dvnrsn commented Apr 30, 2024

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blittle
Copy link
Contributor

blittle commented May 1, 2024

@dvnrsn could you please sign the CLI, follow the instructions here: https://cla.shopify.com/

@dvnrsn
Copy link
Contributor Author

dvnrsn commented May 1, 2024

Yeah sorry. I signed but am unable to retrigger

@michenly
Copy link
Contributor

Hi @dvnrsn I re-trigger the check but it doesn't look like your CLA was register.
Do you want to try again. I can merge without it if you are ok with that.

@dvnrsn
Copy link
Contributor Author

dvnrsn commented May 29, 2024

Weird, it tells me GitHub username has already signed a CLA but yeah this is kind of trivial; you can add it to one of your other PRs or merge it.

@michenly
Copy link
Contributor

@dvnrsn super strange. Thanks for trying again! I will merge for now.

@michenly michenly merged commit a739f35 into Shopify:main May 30, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants