Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SetUnion, SetIntersect and SetDiff to IDatabase. All of them are used SetCombine method #2708

Closed
wants to merge 2 commits into from

Conversation

mohsenbgi
Copy link

Added SetUnion, SetIntersect and SetDiff to IDatabase.
All of them are used SetCombine method

@NickCraver
Copy link
Collaborator

Hey there! I'm curious what functionality is missing in the current APIs here - can you please explain what's not current covered by the SetCombine(AndStore)(Async) methods today?

@mohsenbgi
Copy link
Author

Hi there, I think that if Redis commands are named intuitively, they can be easier to use and enhance the readability of the code.

@NickCraver
Copy link
Collaborator

I hear you, and that's certainly a good argument I agree with for any new APIs being added to be intuitive as always, but adding duplicate commands creating both confusion and a lot of overhead does not further that goal.

If we have thoughts on how to make the existing APIs more discoverable, certainly open to options there but we shouldn't add dozens of duplicates to the surface area to achieve that :)

@mohsenbgi
Copy link
Author

You're right. Thanks for taking the time to review 🙌.

@mohsenbgi mohsenbgi closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants