(Go version) Multi platform build #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tlimoncelli @atma-stackoverflow mind taking a look? Note that building the Windows version currently fails: #320 |
|
I've never tried building this on Windows but I'll sent a PR that fixes the immediate problem. The tests definitely won't run and will require a bigger project. |
|
Would you see value in providing a Windows binary? Seems to me that this could be useful and one of the benefits of the Go port. |
|
Merge in these changes to get a working Windows build. NB: the tests won't work, but it will compile. #321 |
|
@tlimoncelli @atma-stackoverflow I just added a branch protection rule for the |
tlimoncelli
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a precursor to adding a release workflow (#318): build Linux, Windows, and Darwin binaries. Inspired by dnscontrol.