GANDI: Gandi v5 auth changes #2726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llange
force-pushed
the
gandi_v5-auth-changes
branch
2 times, most recently
from
4256b96
to
bd136ec
Compare
|
Well it looks that the promising |
|
Yeah, I'd remove the dryrun feature. Seems like it will create more confusion than help. |
llange
force-pushed
the
gandi_v5-auth-changes
branch
from
352b45b
to
3867899
Compare
tlimoncelli
reviewed
Dec 18, 2023
| // SharingID: client.sharingid, | ||
| // Debug: client.debug, | ||
| // }) | ||
| // g := NewLiveDNSClient(client) |
There was a problem hiding this comment.
"N" should be lowercase. There's no need to export this function.
|
I'm a Gandi user so I was very excited to see this PR. However I don't seem to be able to make this work with my configuration. From the debug output, it looks like it is using the Bearer token for most system calls, but not all. In particular, GetNameservers and GetRegistrarCorrections don't seem to be updated to use the Bearer token (PAT). My creds.json entry: The output with debug: |
|
For integration tests to work, the providers.json file needs to be updated: |
|
Another suggestion: |
|
Drat. I can't figure out what settings are required to make a PAT that works for me. I even created a PAT that has all the DNS-related roles:
|
llange
force-pushed
the
gandi_v5-auth-changes
branch
from
8cb583c
to
a8feba5
Compare
I agree with those settings, these are the ones I use with success. My PATs are even limited to "products" (domain names) to further isolate the impact. |
llange
force-pushed
the
gandi_v5-auth-changes
branch
from
a8feba5
to
edd8ce2
Compare
This seems linked to your previous error : "it looks like it is using the Bearer token for most system calls, but not all" ? If so it's unrelated to the PAT itself. |
llange
force-pushed
the
gandi_v5-auth-changes
branch
from
edd8ce2
to
a6a79bc
Compare
llange
force-pushed
the
gandi_v5-auth-changes
branch
from
a6a79bc
to
5b9d26a
Compare
It's my fault, I patched only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the new default auth mechanism for GANDI_V5 API (
token) now that theapikeyis officialy deprecated.The change should be transparent for existing users still using the
apikeyentry.Other changes to
creds.jsoninclude:apiurlsetting to control then endpoint and allowing to use the sandbox endpointdryrunsetting to allow DryRun use of certain API verbs (untested)Please note that I had no success creating a domain in the sandbox environment, thus was not able to validate that everything was working as expected there. However, the API calls are (of course) properly sent to
apiurland the authentication works there.(notifying maintainer: @TomOnTime @tlimoncelli)