BUG: ZSH Autocomplete does not work if installed as a file #2955 #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge#2955 The #compdef directive shouldn't have double-quotes. (https://zsh.sourceforge.io/Doc/Release/Completion-System.html#Autoloaded-files) We need to execute the function the first time when its loaded as described by https://zsh.sourceforge.io/Doc/Release/Functions.html#Autoloading-Functions > [If the KSH_AUTOLOAD option is not set] the function body (with no surrounding `funcname() {...}``) is taken to be the complete contents of the file. This form allows the file to be used directly as an executable shell script. If processing of the file results in the function being re-defined, the function itself is not re-executed. To force the shell to perform initialization and then call the function defined, the file should contain initialization code (which will be executed then discarded) in addition to a complete function definition (which will be retained for subsequent calls to the function), and a call to the shell function, including any arguments, at the end. To keep direct sourcing possible still use `zsh_eval_context` (https://zsh.sourceforge.io/Doc/Release/Parameters.html#Parameters-Set-By-The-Shell) to detect wether the script is being auto-loaded.
|
CC @whi-tw |
whi-tw
approved these changes
May 14, 2024
|
Thanks! All the zsh users thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2955
The #compdef directive shouldn't have double-quotes. (https://zsh.sourceforge.io/Doc/Release/Completion-System.html#Autoloaded-files)
We need to execute the function the first time when its loaded as described by https://zsh.sourceforge.io/Doc/Release/Functions.html#Autoloading-Functions
To keep direct sourcing possible,
zsh_eval_contextis used (https://zsh.sourceforge.io/Doc/Release/Parameters.html#Parameters-Set-By-The-Shell) to detect wether the script is being auto-loaded.