feat(core): Ensure that Ghost was started #612
Conversation
lib/commands/run.js
Outdated
| instance.process.error(message.error); | ||
| // Ghost error log happens AFTER this event | ||
| // REMOVE WHEN ghost is released and we bump the cli engine? | ||
| setTimeout(() => { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/commands/start.js
Outdated
| }; | ||
|
|
||
| return this.ui.run(start, 'Starting Ghost', runOptions).then(() => { | ||
| // @TODO: shouldn't this happen before start? |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
test/unit/process-manager-spec.js
Outdated
| const ProcessManager = require('../../lib/process-manager'); | ||
|
|
||
| describe('Unit: Process Manager', function () { | ||
| let sandbox; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
force-pushed
the
ipc-lol
branch
2 times, most recently
from
079b2a5
to
1ed5c93
Compare
closes TryGhost#472 - added port polling utility - general process manager class offers `ensureStarted` function - systemd extension makes use of `ensureStarted`
kirrg001
changed the title
lib/process-manager.js
Outdated
| * @returns {Promise<any>} | ||
| */ | ||
| ensureStarted(options) { | ||
| options = merge({ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
lib/utils/port-polling.js
Outdated
| const errors = require('../errors'); | ||
|
|
||
| module.exports = function portPolling(options) { | ||
| options = merge({ |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| * | ||
| * @returns {Promise<any>} | ||
| */ | ||
| ensureStarted(options) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
tested this and it works 👍 just need the above changes fixed and this is good to go. |
|
@acburdine cool 👍 will push your suggestions |
|
Pushed 2 commits 👍 |
closes #472
ensureStartedfunctionensureStarted