Direct & compact tx serialization #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
force-pushed
the
direct_serial_splib
branch
from
23435eb
to
46022cd
Compare
jeffro256
force-pushed
the
direct_serial_splib
branch
2 times, most recently
from
519fdff
to
10924f9
Compare
UkoeHB
requested changes
Mar 28, 2024
jeffro256
force-pushed
the
direct_serial_splib
branch
2 times, most recently
from
82fe608
to
1db5587
Compare
txs are [de]serialized directly from their classes and sizes of containers are not serialized if they can be implied.
jeffro256
force-pushed
the
direct_serial_splib
branch
from
1db5587
to
ed6b63e
Compare
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Apr 11, 2024
This PR is upstreaming changes in the Seraphis lib here: UkoeHB#39. This header adds a macro `VA_ARGS_COMMAPREFIX` which, when passed `__VA_ARGS__`, expands to `, __VA_ARGS__` unless the length of `__VA_ARGS__` is 0, in which case it expands to nothing. This macro is useful for passing/declaring optional function arguments.
jeffro256
added a commit
to jeffro256/monero
that referenced
this pull request
Apr 11, 2024
This PR is upstreaming changes in the Seraphis lib here: UkoeHB#39. The changes to the serialization header allow clean passing of extra arguments to field serialization in the DSL. This is used mainly to pass implied sizes of containers during deserialization to make the format more compact. For example, if my object has two containers A & B which must be the same size, I can serialize only the size of container A. Then, during deserialization, when I deserialize A, I can then use A's size to deserialize B. Depends on monero-project#9286.
Merged
UkoeHB
approved these changes
May 2, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Txs are [de]serialized directly from their classes and sizes of containers are not serialized
if they can be implied.