-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken CurrencyInputDropdown for mobile devices #7287
base: main
Are you sure you want to change the base?
fix: broken CurrencyInputDropdown for mobile devices #7287
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
@JFrankfurt @natew is this an issue? What is the fix for code coverage decreases? |
Since it's a single character copy change you don't need to worry about it. Technically you could probably address that with a unit test that asserts text content or does a snapshot test on the component fragment. |
@JFrankfurt @natew I wrote a test checking for Select Token. This should satisfy code coverage requirements. |
I suggest you use media queries to reduce the font-size for mobile devices; otherwise, the current font-size will still appear broken text on smaller screen devices like the iPhone SE. you can change the
|
Description
Fixes #7286
Screen capture
Test plan