Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup ComponentUtil#legacyToJsonString behavior with styles #3868

Merged
merged 3 commits into from
May 21, 2024

Conversation

FlorianMichael
Copy link
Member

Looking at the git history and the old code it seems that this was missed previously, item name in 1.12->1.13 and item lore in 1.13->1.14 should both be italic default (I tested this using native server and client versions).

Looking at the git history and the old code it seems that this was missed previously, item name in 1.12->1.13 and item lore in 1.13->1.14 should both be italic default (I tested this using native server and client versions).
Copy link
Member

@kennytv kennytv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break items with color formatting

@FlorianMichael
Copy link
Member Author

Did some testing with various items with custom name and lore on a 1.12 server with both 1.12 and 1.16 client and they look equal now, tested items:

minecraft:fishing_rod 1 0 {display:{Lore:["§aHello","§b§kWorld"]}}
minecraft:fishing_rod 1 0 {display:{Lore:["Test"]}}
minecraft:stone 1 0 {display:{Name:"Test"}}
minecraft:stone 1 0 {display:{Name:"§aTest"}}

@FlorianMichael FlorianMichael changed the title Fix custom item names not being italic in 1.12->1.13 Fixup ComponentUtil#legacyToJsonString behavior with styles May 20, 2024
@kennytv kennytv merged commit 9547cf1 into dev May 21, 2024
2 checks passed
@kennytv kennytv deleted the fix/legacy-to-json-italic-conversion branch May 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants