Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/lab ui update design system vars #2102

Closed
wants to merge 29 commits into from
Closed

refactor/lab ui update design system vars #2102

wants to merge 29 commits into from

Conversation

enesozturk
Copy link
Contributor

@enesozturk enesozturk commented Apr 2, 2024 •
edited

Changes

  • Refactored our laboratory UI to use Tailwind, Radix, and Shadcn UI approach
  • Updated our w3m design system variable to have a new look.

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 5:35pm
web3modal-gallery ✅ Ready (Inspect) Visit Preview Apr 15, 2024 5:35pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Apr 15, 2024 5:35pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Apr 15, 2024 5:35pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Apr 15, 2024 5:35pm

tomiir
tomiir approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 🔥
Left a couple of comments on code style but lgtm in general

apps/laboratory/package.json Outdated Show resolved Hide resolved
apps/laboratory/src/components/Ethers/EthersSignMessageTest.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/components/Ethers/EthersSignTypedDataTest.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/components/Solana/SolanaSignMessageTest.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/components/configuration-dialog.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/components/ui/dropdown-menu.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/components/ui/dropdown-menu.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/pages/index.tsx Outdated Show resolved Hide resolved
apps/laboratory/src/pages/index.tsx Outdated Show resolved Hide resolved
apps/laboratory/tsconfig.json Show resolved Hide resolved
@lukaisailovic
Copy link
Contributor

It seems like tests are broken. Let's make sure they are passing before we merge this

@enesozturk enesozturk mentioned this pull request Apr 14, 2024
Closed
@enesozturk enesozturk force-pushed the refactor/lab-ui-update-design-system-vars branch from 9367b53 to 4f3f494 Compare April 15, 2024 16:46
@enesozturk enesozturk closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enesozturk @lukaisailovic @tomiir