Use -1 when name_ttl is not specified on name_update events #3843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, there's no way to distinguish on the env event if the AENS update was called using `Some(0)` (update the name to expire immediately) or `None` (don't update the name TTL). This implementation now returns name_ttl = 0 when it was supposed to expire immediately and `name_ttl = -1` when the name_ttl is supposed to remain untouched.
|
Isn't there exactly the same issue with pointers (and client_ttl) - where we also sometimes pass |
|
@hanssv what default values do you suggest using for these two cases? |
|
For |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there's no way to distinguish on the env event if the AENS
update was called using
Some(0)(update the name to expireimmediately) or
None(don't update the name TTL).This implementation now returns name_ttl = 0 when it was supposed to
expire immediately and
name_ttl = -1when the name_ttl is supposedto remain untouched.