[GH-757] Add delegates to Channel.Worker #809

cytadela8 · 2018-11-29T15:58:18Z

Added delegates functionality to Channel Worker.
Adjusted transaction checks
Added tests for Delegates

Resolves #757

in SoloClose and Slash

thepiwo

looks good to me, didn't check in detail

d-velev · 2018-11-30T12:08:10Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -779,6 +818,10 @@ defmodule Aecore.Channel.ChannelStatePeer do
  Retrieves our offchain account balance from the latest offchain chainstate
  """
  @spec our_offchain_account_balance(ChannelStatePeer.t()) :: non_neg_integer()
+  def our_offchain_account_balance(%ChannelStatePeer{role: :delegate}) do
+    throw({:error, "#{__MODULE__}: Delagate doesn't have a balance"})


Are the throws handled anywhere and can they be replaced with regular {:error, _} returns?

This should only throw due to programmer error. It doesn't make sense to take a balance of delegate. It makes even less sens to get foreign_offchain_account_balance when ChannelStatePeer is for delegate.

We use this functions only in places where it's know the ChannelStatePeer.role is not delegate.

gorbak25

Good code, some small typos.

gorbak25 · 2018-12-12T00:56:10Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

+  def receive_half_signed_tx(_, _, _, _opts \\ %{})
+
+  def receive_half_signed_tx(%ChannelStatePeer{role: :delegate}, _, _, _) do
+    {:error, "#{__MODULE__}: Deleagte can't handle half_signed_txs"}


Deleagte -> Delegate

gorbak25 · 2018-12-12T00:58:21Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

  def receive_half_signed_tx(
        %ChannelStatePeer{fsm_state: :open} = peer_state,
        tx,
        privkey,
-        opts \\ %{}
+        opts


By default no additional options should be passed for update validation.

gorbak25 · 2018-12-12T00:59:42Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -927,6 +978,10 @@ defmodule Aecore.Channel.ChannelStatePeer do
          {non_neg_integer(), non_neg_integer()},
          Keys.sign_priv_key()
        ) :: {:ok, ChannelStatePeer.t(), SignedTx.t()} | error()
+  def receive_close_tx(%ChannelStatePeer{role: :delegate}, _, _, _, _) do
+    {:error, "#{__MODULE__}: Deleagte can't receive close tx"}


Deleagte -> Delegate

gorbak25 · 2018-12-12T00:59:58Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -1002,6 +1057,10 @@ defmodule Aecore.Channel.ChannelStatePeer do
          non_neg_integer(),
          Keys.sign_priv_key()
        ) :: {:ok, ChannelStatePeer.t(), SignedTx.t()} | error()
+  def solo_close(%ChannelStatePeer{role: :delegate}, _, _, _) do
+    {:error, "#{__MODULE__}: Delagate can't solo close"}


Delagate -> Delegate

gorbak25 · 2018-12-12T01:01:37Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -1060,7 +1125,7 @@ defmodule Aecore.Channel.ChannelStatePeer do
          poi: dispute_poi_for_latest_state(peer_state),
          offchain_tx: ChannelTransaction.dispute_payload(most_recent_tx)
        },
-        our_pubkey(peer_state),
+        pubkey,


If the role is :initiator or :responder we should check that pubkey == our_pubkey(peer_state)

gorbak25 · 2018-12-12T01:02:15Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -1090,6 +1156,7 @@ defmodule Aecore.Channel.ChannelStatePeer do
        },
        fee,
        nonce,
+        pubkey,


Same as above

gorbak25 · 2018-12-12T01:02:35Z

apps/aecore/lib/aecore/channel/channel_state_peer.ex

@@ -1180,6 +1251,10 @@ defmodule Aecore.Channel.ChannelStatePeer do
  """
  @spec settle(ChannelStatePeer.t(), non_neg_integer(), non_neg_integer(), Keys.sign_priv_key()) ::
          {:ok, SignedTx.t()} | error()
+  def settle(%ChannelStatePeer{role: :delegate}, _, _, _) do
+    {:error, "#{__MODULE__}: Deleagte can't settle"}


Deleagte -> Delegate

cytadela8 added 5 commits November 23, 2018 00:28

Adjusted slashing checks

9297203

[GH-757] Check if sender is peer or delegate

78d46a8

in SoloClose and Slash

[GH-757] Added delegates handling to Channel.Worker

522642f

[GH-757] Test delegate server

299b300

[GH-757] Fixed importing channels

6fac8dc

cytadela8 added the channel label Nov 29, 2018

cytadela8 self-assigned this Nov 29, 2018

cytadela8 requested review from gorbak25 and thepiwo November 29, 2018 15:58

[GH-757] Adjusted checks for epoch v1.0.0

563af70

cytadela8 requested a review from DanielaIvanova November 29, 2018 17:33

cytadela8 added 2 commits November 30, 2018 01:58

[GH-757] Better tests

1eb1f54

Merge branch 'master' into GH-757

399530d

thepiwo approved these changes Nov 29, 2018

View reviewed changes

thepiwo requested a review from d-velev November 30, 2018 10:07

DanielaIvanova approved these changes Nov 30, 2018

View reviewed changes

d-velev reviewed Nov 30, 2018

View reviewed changes

gorbak25 reviewed Dec 12, 2018

View reviewed changes

gorbak25 changed the title ~~[GH-757] Add delagates to Channel.Worker~~ [GH-757] Add delegates to Channel.Worker Dec 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-757] Add delegates to Channel.Worker #809

[GH-757] Add delegates to Channel.Worker #809

cytadela8 commented Nov 29, 2018 •

edited

thepiwo left a comment

d-velev Nov 30, 2018

thepiwo Dec 3, 2018

cytadela8 Dec 4, 2018

cytadela8 Dec 4, 2018

gorbak25 left a comment

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

gorbak25 Dec 12, 2018

@@ @@ -1090,6 +1156,7 @@ defmodule Aecore.Channel.ChannelStatePeer do @@
                       },
                       fee,
                       nonce,
+                      pubkey,

[GH-757] Add delegates to Channel.Worker #809

Are you sure you want to change the base?

[GH-757] Add delegates to Channel.Worker #809

Conversation

cytadela8 commented Nov 29, 2018 • edited

thepiwo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gorbak25 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cytadela8 commented Nov 29, 2018 •

edited