-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-detect of attachments extension [playwright] #470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
theme:api
Javascript API related issue
theme:playwright
labels
Jul 27, 2022
baev
requested changes
Jul 27, 2022
@elipskiy Thank you for contribution! 🙏 |
@elipskiy some tests are failed. Could you fix it? |
vovsemenv
approved these changes
Aug 15, 2022
@baev we ready to go |
elipskiy
force-pushed
the
file-extension
branch
from
September 9, 2022 11:17
2b75dd7
to
23175e0
Compare
@baev please, merge this pr |
The PR isn't merged yet due to the following concerns:
|
fixed via #956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Playwright Reporter missed attachments whose extensions could not detect from content type.
Add auto detect file extensions from the file name.
Checklist