-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for links to issues and tms for codeceptjs #639
Conversation
1911e8c
to
91a7c44
Compare
91a7c44
to
8a4c9dd
Compare
@vovsemenv is this feature right for you? |
Hello @guiyomh! Looking good, but I have thoughts that this feature needs to be handled by the report-generator side of allure. I will add more detailed review later |
You mean make a java plugin that does this job? |
yep |
I think it's a good idea, but I don't know the plugin system very well. @vovsemenv do you know where can I found documentation about this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! Thanks for the contribution! 🚀
Maybe we should align the configuration with the other integrations? For example, in Allrue Codeception https://github.com/allure-framework/allure-codeception, we added support for different link types.
@vovsemenv @guiyomh we'll add tags processing on the generator side for labels. Still, the links should be processed independently at the framework side because links require additional configuration (link patterns), and users may build an aggregated report from different tests, which my require different link patterns per test type. |
BTW for allure-cucumberjs we have the following config https://github.com/allure-framework/allure-js/tree/master/packages/allure-cucumberjs We really need to try harder to align simular features between the frameworks 🤪 |
If you want, I can do other PR to align other framework on this MR. |
fixed via #968 |
@guiyomh thanks anyway! |
Context
I want use allure xray plugin, but I must configure link on my test.
So, I propose this PR to set up the links to issue and tms.
Issue Link
Setup codeceptjs plugin with:
const { setHeadlessWhen, setCommonPlugins } = require("@codeceptjs/configure"); const path = require("path"); setCommonPlugins(); module.exports.config = { tests: "./**/*.test.js", output: path.resolve(__dirname, "./output"), plugins: { allure: { enabled: true, require: "allure-codeceptjs", + issueURlTemplate: "https://example.qameta.io/allure-framework/allure-js/issues/%s", }, }, };
TMS Link
Setup codeceptjs plugin with:
const { setHeadlessWhen, setCommonPlugins } = require("@codeceptjs/configure"); const path = require("path"); setCommonPlugins(); module.exports.config = { tests: "./**/*.test.js", output: path.resolve(__dirname, "./output"), plugins: { allure: { enabled: true, require: "allure-codeceptjs", + tmsURLTemplate: "https://example.qameta.io/allure-framework/allure-js/tests/%s", }, }, };
Checklist