Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add currentTest init earlier than testStarted #692

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

add currentTest init earlier than testStarted #692

wants to merge 15 commits into from

Conversation

hatufacci
Copy link
Contributor

@hatufacci hatufacci commented May 29, 2023 •
edited by baev

Context

fixes #691

Checklist

@hatufacci hatufacci mentioned this pull request May 29, 2023
Open
baev
baev requested changes May 29, 2023
View reviewed changes
packages/allure-codeceptjs/src/index.ts Outdated Show resolved Hide resolved
@baev baev added the type:improvement Improvement or request label May 29, 2023
@hatufacci hatufacci requested a review from baev May 29, 2023 13:01
@baev
Copy link
Member

baev commented May 30, 2023

As far as I understand, you're trying to set a description to test from before hooks. But what if the suite has multiple tests? The description will be only set to the first one, is it right?

@hatufacci
Copy link
Contributor Author

hatufacci commented May 31, 2023 •
edited

As far as I understand, you're trying to set a description to test from before hooks. But what if the suite has multiple tests? The description will be only set to the first one, is it right?

@baev i changed method where we init currentTest variable to createTest(), it could handle all cases where we createTest and changed unit test too

@hatufacci
Copy link
Contributor Author

hatufacci commented May 31, 2023 •
edited

@baev build was failed because of another tests, that don't connected with fix

@hatufacci
Copy link
Contributor Author

@vovsemenv could you take a look?

@hatufacci
Copy link
Contributor Author

@vovsemenv Hey, could you take a look? i've prepared it more than 2 month ago

@vovsemenv vovsemenv removed their request for review February 22, 2024 09:00
@baev baev removed their request for review February 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev requested changes

@vovsemenv vovsemenv vovsemenv requested changes

@peterngtr peterngtr peterngtr approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
theme:codeceptjs type:improvement Improvement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

description method doesn't work for codeceptjs before hook, and event.started
4 participants
@hatufacci @baev @vovsemenv @peterngtr