-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add experimental and zoneless to nav #55834
Conversation
Deployed adev-preview for 296cb42 to: https://ng-dev-previews-fw--pr-angular-angular-55834-adev-prev-n9l7hy9f.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -640,6 +640,12 @@ const DOCS_SUB_NAVIGATION_DATA: NavigationItem[] = [ | |||
}, | |||
], | |||
}, | |||
{ | |||
label: 'Experimental features', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonaco Going one level higher would require some subcategories in that case. Do you envision something like:
/in-depth-guides
| -- Components
| -- Template Syntax
/feature-preview
|-- Dev Preview
| |-- Zoneless
|-- Experimental
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah let's keep it as is then. And we can iterate if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought, when we late move pages like this to their "correct" home, it causes confusion for developers because it moves out of the "Preview" sections, then they can't find it.
I'm good with adding an "Experimental features" section, but can we also add the page to where it goes in the in-depth guides to reduce the change later?
This PR was merged into the repository by commit acdcec9. |
No description provided.