-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.10 support for the controller #83221
base: devel
Are you sure you want to change the base?
Conversation
@@ -32,27 +32,8 @@ def import_module(name): # type: ignore[misc] | |||
__import__(name) | |||
return sys.modules[name] | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Python module needs to support target Python versions, not just controller Python versions. So the Python 2.7 support can be dropped, but not Python 3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a related note, there is more Python 2.7 code that can be removed, such as the use of ansible.module_utils.six
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansible.module_utils.six
is used in quite a few collections all over the place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not removing that feature -- we're just discontinuing use of it in core where it's no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's totally sensible :) Thanks for clarifying!
This PR is blocked on completion of #83093 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've restarted the tests now that the AZP container has been updated to include Python 3.11. Before this PR is merged we should check on the status of the updates to the other projects using AZP: ansible-collections/news-for-maintainers#71 Any projects testing against |
The test
|
# Remove this once py3.11 is our controller minimum | ||
# Workaround for https://bugs.python.org/issue47231 | ||
# See _extract_tar_dir | ||
collection_tar._ansible_normalized_cache = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are unit tests that still refer to this and will need to be updated.
SUMMARY
Fixes #83094
ISSUE TYPE