-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: constrain the connection
input of sendTransaction
to the minimum interface actually required
#848
Open
steveluscher
wants to merge
1
commit into
master
Choose a base branch
from
constrain-that-connection-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveluscher
commented
Nov 29, 2023
Comment on lines
+8
to
+21
type BlockhashFetcher = (config?: { | ||
commitment?: Commitment; | ||
minContextSlot?: number; | ||
}) => Promise<{ blockhash: string }>; | ||
|
||
export interface ConnectionContext { | ||
commitment?: Commitment; | ||
getLatestBlockhash: BlockhashFetcher; | ||
sendRawTransaction( | ||
rawTransaction: Buffer | Uint8Array | Array<number>, | ||
options?: SendOptions | ||
): Promise<TransactionSignature>; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Start here.
steveluscher
force-pushed
the
constrain-that-connection-interface
branch
from
November 29, 2023 01:25
341e3dc
to
74a3f7f
Compare
This was referenced Nov 29, 2023
steveluscher
force-pushed
the
constrain-that-connection-interface
branch
from
May 10, 2024 22:20
74a3f7f
to
8907d29
Compare
Rebased. I still think this is worth doing. Are you opposed to this in any way @jordaaash? |
…inimum interface actually required
steveluscher
force-pushed
the
constrain-that-connection-interface
branch
from
May 10, 2024 22:21
8907d29
to
a0ef497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sendTransaction()
method takes in aConnection
from@solana/web3.js
but actually requires very little of it; justcommitment
,sendRawTransaction()
, andgetLatestBlockhash()
.In this PR we constrain the interface to exactly that and no more. This will make it easier to supply non
@solana/web3.js
implementations at that callsite, so long as they can fulfil the same contract.