[Not for review] Check NACK messages

[vusirikala]

Description

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 7h 9m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-smoke-tests	1h 45m	🟩 🟩 🟩
forge-e2e-test / forge	55m	🟩 🟩 🟩
forge-compat-test / forge	45m	🟩 🟩 🟩
rust-images / rust-all	41m	🟩 🟩 🟩
cli-e2e-tests / run-cli-tests	34m	🟥 🟥 🟥
rust-targeted-unit-tests	30m	🟩 🟩 🟩
rust-lints	21m	🟩 🟩 🟩
rust-build-cached-packages	20m	🟩 🟩 🟩
rust-move-tests	12m	⬜ 🟩 🟩 🟩
run-tests-main-branch	12m	🟩 🟩 🟩
check	11m	🟩 🟩 🟩
test-target-determinator	10m	🟩 🟩 🟩
execution-performance / test-target-determinator	10m	🟩 🟩 🟩
general-lints	5m	🟩 🟩 🟩
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose	5m	🟩 🟩 🟩
check-dynamic-deps	5m	🟩 🟩 🟩 🟩
node-api-compatibility-tests / node-api-compatibility-tests	3m	🟩 🟩 🟩
semgrep/ci	2m	🟩 🟩 🟩 🟩
file_change_determinator	44s	🟩 🟩 🟩 🟩
file_change_determinator	32s	⬜ 🟩 🟩 🟩
file_change_determinator	29s	🟩 🟩 🟩
execution-performance / single-node-performance	23s	🟩 🟩 🟩
permission-check	16s	🟩 🟩 🟩 🟩
permission-check	12s	🟩 🟩 🟩 🟩
permission-check	10s	🟩 🟩 🟩 🟩
permission-check	10s	🟩 🟩 🟩 🟩
permission-check	9s	🟩 🟩 🟩
determine-docker-build-metadata	6s	🟩 🟩 🟩

🚨 6 jobs on the last run were significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
cli-e2e-tests / run-cli-tests	9m	6m
forge-e2e-test / forge	19m	15m
forge-compat-test / forge	16m	14m
rust-targeted-unit-tests	8m	19m
rust-move-tests	3m	9m
execution-performance / single-node-performance	9s	23m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite compat success on 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cf7aadac6addf5413986c857a226f4655019474a

Compatibility test results for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cf7aadac6addf5413986c857a226f4655019474a (PR)
1. Check liveness of validators at old version: 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411
compatibility::simple-validator-upgrade::liveness-check : committed: 6738.404321390681 txn/s, latency: 4859.716321949655 ms, (p50: 4800 ms, p90: 8100 ms, p99: 8700 ms), latency samples: 249480
2. Upgrading first Validator to new version: cf7aadac6addf5413986c857a226f4655019474a
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1753.2170904992681 txn/s, latency: 16244.604113636364 ms, (p50: 19900 ms, p90: 21600 ms, p99: 22200 ms), latency samples: 88000
3. Upgrading rest of first batch to new version: cf7aadac6addf5413986c857a226f4655019474a
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1836.2271469544744 txn/s, latency: 15614.570939611947 ms, (p50: 18200 ms, p90: 22200 ms, p99: 22500 ms), latency samples: 91740
4. upgrading second batch to new version: cf7aadac6addf5413986c857a226f4655019474a
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3575.9822796315284 txn/s, latency: 8806.111031954628 ms, (p50: 9600 ms, p90: 12700 ms, p99: 13000 ms), latency samples: 144580
5. check swarm health
Compatibility test for 3ffe0986b5fe4acb76544ae7ae85d73b91a6a411 ==> cf7aadac6addf5413986c857a226f4655019474a passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on cf7aadac6addf5413986c857a226f4655019474a

two traffics test: inner traffic : committed: 8264.283030780085 txn/s, latency: 4738.427697473635 ms, (p50: 4500 ms, p90: 5700 ms, p99: 10700 ms), latency samples: 3576680
two traffics test : committed: 99.9352845446937 txn/s, latency: 1843.1888888888889 ms, (p50: 1800 ms, p90: 2000 ms, p99: 2300 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.209, avg: 0.203", "QsPosToProposal: max: 0.233, avg: 0.221", "ConsensusProposalToOrdered: max: 0.439, avg: 0.387", "ConsensusOrderedToCommit: max: 0.386, avg: 0.368", "ConsensusProposalToCommit: max: 0.773, avg: 0.756"]
Max round gap was 1 [limit 4] at version 1423348. Max no progress secs was 4.984218 [limit 15] at version 1423348.
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking