-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify pipeline parsing with using
declarations
#16216
base: main
Are you sure you want to change the base?
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56142/ |
b092ddd
to
c87e1da
Compare
3c17c6c
to
b5a600f
Compare
I personally tend to use |
I will try to do some benchmarks |
This PR introduces a performance regression indeed, we should not merge it until I figure out how to solve it. However, it also looks like we currently have a big perf regression on This PR: ➜ node ./benchmark/babel-parser/real-case/bench.mjs
current 4 jquery 3.6: 13.21 ops/sec ±1.75% (76ms)
baseline 4 jquery 3.6: 22.71 ops/sec ±2.19% (44ms)
current 4 jquery 3.6: 13.32 ops/sec ±1.58% (75ms)
baseline 4 jquery 3.6: 22.31 ops/sec ±2.49% (45ms)
where |
Please use To be honest, I'm surprised that this is reflected in |
It's because parsing for the |
This is mostly an experiment to see how
using
declarations can simplify our state management in the parser (currently we have a lot of intermediate functions to hidetry
/finally
statements).I also have other drafts to see how migrating to
using
looks like: https://github.com/nicolo-ribaudo/babel/pull/10/files?w=1, https://github.com/nicolo-ribaudo/babel/pull/11/files?w=1I'll also open a PR to remove the F# and smart proposals in babel 8, since they are unfortunately not being pursued anymore.