Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading a package does not add/remove links #28

Open
pjeby opened this issue Jun 23, 2017 · 5 comments
Open

Upgrading a package does not add/remove links #28

pjeby opened this issue Jun 23, 2017 · 5 comments
Labels

Comments

@pjeby
Copy link
Contributor

pjeby commented Jun 23, 2017

The upgrade command issues a pull, but before that it should unlink everything, then relink after pulling. Otherwise, new commands, completions and man pages aren't installed, and old ones aren't removed.

@juanibiapina
Copy link
Member

That is true.

@juanibiapina
Copy link
Member

I was thinking in actually just running uninstall and install again, which would solve problems with links, completions, man pages, etc.

This would also upgrade packages which were installed with a tag, effectively making them upgradable. cc @YarekTyshchenko

@YarekTyshchenko
Copy link
Contributor

I often run:

basher outdated | xargs -n 1 basher upgrade

But I have seen problems where weird repo history caused the simple git commands run by basher to fail. I'd be happy with a re-install instead of upgrade. Makes the whole thing simpler, and therefore more predictable when shipping software. +1.

@juanibiapina
Copy link
Member

juanibiapina commented Sep 30, 2017

This only causes a problem when the repo is saving information inside its own directory structure, which I would argue it shouldn't (but basher does 😭 )

soraxas added a commit to soraxas/basher that referenced this issue May 29, 2020
@soraxas soraxas mentioned this issue May 29, 2020
@cornfeedhobo
Copy link
Contributor

cornfeedhobo commented Sep 30, 2023

@juanibiapina Hacktoberfest is right around the corner ;)

@YarekTyshchenko You might like this..

while read -r pkg; do basher uninstall "$pkg" && basher install "$pkg"; done < <(basher outdated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants