Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #28 #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #28 #84

wants to merge 1 commit into from

Conversation

soraxas
Copy link
Contributor

@soraxas soraxas commented May 29, 2020

This PR adds:

  • perform unlink/relink when upgrading a package
  • It also performs upgrade on its dependencies.
  • Exit upgrade gracefully if it's not upgradable (using same logic as outdated) so that unlinking/relinking won't be performed.

This addresses #28

@juanibiapina
Copy link
Member

Again, thanks for your contributions 😄 .

There's two set of changes here, and also it's missing tests. Would you still care to split it and add tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants