Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent package conflicts when linking and uninstalling #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soraxas
Copy link
Contributor

@soraxas soraxas commented May 31, 2020

This PR is aimed to prevent packages conflicts; namely, when two different packages has identical names for binaries/man/completions.

This means avoid the -f flag in ln to NOT overwrite when file exists (a user should resolve packages conflict on their own), and when uninstalling a package it will checks that: if the link to be removed is indeed from the package that we are uninstalling (by resolving the link).

@juanibiapina
Copy link
Member

Thank you! You're right, -f should not be used. If you're still interested, please add tests and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants