-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit log #1357
Add audit log #1357
Conversation
18aeffd
to
0994f82
Compare
@michaelschattgen A small suggestion is to delete the entries greater than 30 days periodically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I've added a couple of comments.
I think the audit log event types you defined cover most of the important events, but I am missing an event for backups made through AegisBackupAgent
. Because Android starts backup agents in a weird restricted mode, this one requires some careful testing to make sure it works correctly.
...java/com/beemdevelopment/aegis/ui/fragments/preferences/ImportExportPreferencesFragment.java
Outdated
Show resolved
Hide resolved
...java/com/beemdevelopment/aegis/ui/fragments/preferences/ImportExportPreferencesFragment.java
Show resolved
Hide resolved
...ain/java/com/beemdevelopment/aegis/ui/fragments/preferences/AuditLogPreferencesFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/database/AuditLogEntry.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AuditLogAdapter.java
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AuditLogHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/AuthActivity.java
Outdated
Show resolved
Hide resolved
0994f82
to
a755ec0
Compare
a755ec0
to
171da34
Compare
I like this feature! I think it should also track when the vault password has been changed. |
@elliotwutingfeng I like that! I'm leaving this pull request for what it is (otherwise it will never get done) but that's definitely going on the backlog. Thanks for the suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
This pull request is aiming to give more insight to important events that occurred within the app. We chose to use a SQLite database in combination with Room. I've made the choice to only show the entries of the last 30 days for now, but we might want to change that in the future.
The events we're currently tracking are:
Feel free to comment on this PR if you think we need to track other events.
This is discussed in #1069 and makes it possible to implement #1132.