-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Auto js fixtures #3649
base: master
Are you sure you want to change the base?
WIP - Auto js fixtures #3649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
- Coverage 29.84% 29.81% -0.03%
==========================================
Files 378 378
Lines 32663 32679 +16
Branches 1752 1752
==========================================
- Hits 9747 9744 -3
- Misses 21642 21658 +16
- Partials 1274 1277 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
43a3ae5
to
c8dba3f
Compare
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
c8dba3f
to
f46b856
Compare
This PR/issue depends on:
|
Depends on #3650
The auto fixtures feature works but there will be problems with generating them consistently:
I won't merge it for now because if it were used, it would require regenerating all snapshots on fixtures regen which would produce a lot of review noise and discourage snapshots diff reviews