Remove unnecessary [ALL] inside hash.

[mathwhiz1212]

Remove unnecessary [ALL] inside hash. Problem found by @coolaj86 who asked me to do a PR.

[aantonop]

I don't think it is unnecessary. ALL is there because it denotes the signature hash type (SIGHASH_ALL)

…

On Tue, Jan 17, 2023, 19:11 mathwhiz1212 ***@***.***> wrote: Remove unnecessary [ALL] inside hash. Problem found by @coolaj86 <https://github.com/coolaj86> who asked me to do a PR. ------------------------------ You can view, comment on, or merge this pull request online at: #1045 Commit Summary - 1a148aa <1a148aa> Remove unnecessary [ALL] - 95cec15 <95cec15> Fix my typo. File Changes (1 file <https://github.com/bitcoinbook/bitcoinbook/pull/1045/files>) - *M* ch06.asciidoc <https://github.com/bitcoinbook/bitcoinbook/pull/1045/files#diff-754c9fa6e12e7320d5e4cd442492c8c4124bf24007e167b818a2b344f8d83547> (6) Patch Links: - https://github.com/bitcoinbook/bitcoinbook/pull/1045.patch - https://github.com/bitcoinbook/bitcoinbook/pull/1045.diff — Reply to this email directly, view it on GitHub <#1045>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJARW4HPT7EUDSWBW4VQF3WS47KHANCNFSM6AAAAAAT6P6YH4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[coolaj86]

@aantonop The [ALL] is an artifact from a bug in the copy function in the Insight Web UI (possibly due to some ellipsis-style truncation in a responsive view or something).

The Sighash Type is encoded in the hex, but the hex obviously won't parse correctly with invalid characters.

Remove the junk characters and it parses as expected.

@mathwhiz1212 the extra newline also needs to be removed.

[coolaj86]

3045 type and length of sig
0221 type and length of R
00 ASN.1 bigint pad
884d142d86652a3f47ba4746ec719bbfbd040a570b1deccbb6498c75c4ae24cb R value
0220 type and length of S
4b9f039ff08df09cbe9f6addac960298cad530a863ea8f53982c09db8f6e3813 S value
01 sighash type all - XXXX
Missing pub key length? - XXXX
04 pub key uncompressed
84ecc0d46f1918b30928fa0e4ed99f16a0fb4fde0735e7ade8416ab9fe423cc5
412336376789d172787ec3457eee41c04f4938de5cc17b4a10fa336a8d752adf Public key value

see dashhive/DashTx.js#1

It looks like 4 hex characters are missing - the sighash type - so maybe it's an encoder bug somewhere calling toString() rather than toString("hex") - and the public key length.

I just did that real quick by hand, but viewing it in fixed width, it checks out. In any case it's obviously invalid and non-parsable hex.