-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www: Make Builder related URLs take buildername #7549
base: master
Are you sure you want to change the base?
www: Make Builder related URLs take buildername #7549
Conversation
f844a12
to
6f6c12f
Compare
6f6c12f
to
f1fef41
Compare
The problem with builder names in URLs is that builder names can change and then all URLs would break. I will think about how this could be solved. The PR itself looks good and would improve user experience. |
I agree that it can be an issue (in addition to #7552). But, maybe I missed something, but builderid seem to not be stable either in case of name change right? |
You're completely right. Buildername has 1:1 relationship with builderid. Which means that there are no blockers for this PR. |
f1fef41
to
670dc58
Compare
Still think merging this should be on hold until #7552 is addressed as this would add onto the inconsistency of which builder can be accessed by name. |
670dc58
to
ecf6beb
Compare
This allow to share user-friendly URLs between users.
Note that using
buildername
in APIs can be problematic, see #7552.Contributor Checklist:
newsfragments
directory (and read theREADME.txt
in that directory)