-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-base: Minor fix and improvement to ForceBuildModal fields #7571
react-base: Minor fix and improvement to ForceBuildModal fields #7571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a while to agree that this PR makes sense after all.
fea991d
to
baddede
Compare
@tdesveaux Does this PR really not need a newsfragment? It does fix something. |
You're right, I can't remember why I thought differently. |
baddede
to
4f73e13
Compare
www/react-base/src/components/ForceBuildModal/Fields/FieldInt.tsx
Outdated
Show resolved
Hide resolved
642fa9c
to
30dcdd9
Compare
'Form.Control' with 'multiple' prop expect 'value' to be an array of values.
30dcdd9
to
a4eda76
Compare
Mainly fix
FieldChoiceString
withmultiple
.Biggest change was to untype the value stored by
ForceBuildfieldsState
as storing everything as string would be awkward in some places and I don't think it brought much to type it.Contributor Checklist:
newsfragments
directory (and read theREADME.txt
in that directory)