Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/check translation script #905

Merged

Conversation

anmol-fzr
Copy link
Contributor

Issue link / number:

#890

What changes did you make?

Added script to check translations have been provided or not

Why did you make the changes?

  • Add a script which checks that our translation files are correct.
  • for each enabled language that the messages .json files exist for every folder. i.e. shared/en.json, shared/hi.json etc.. all exist
  • for each file, ensure there is a matching key value pair in every file.
  • if either of these is not true, print a warning mentioning, language and the key.
  • Add the script to the package json. It should be called something like "check:translations".

Did you run tests?

I tested the script
Screenshot-2024-05-12_18-02-33

Copy link

vercel bot commented May 12, 2024

@anmol-fzr is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@kyleecodes kyleecodes self-assigned this May 15, 2024
Copy link
Member

@kyleecodes kyleecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution.

Note: Can confirm new checkTranslation script functions.

package.json Show resolved Hide resolved
@kyleecodes kyleecodes merged commit 4d1f716 into chaynHQ:develop May 17, 2024
3 of 4 checks passed
@cypress cypress bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants