Improve usability of refund #1571
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about |
|
Please work on an accompanying test, you could use this one as a starting point |
binarybaron
reviewed
May 25, 2024
| db.insert_latest_state(swap_id, state.clone().into()) | ||
| .await?; | ||
|
|
||
| println!("{}", refund_error); |
There was a problem hiding this comment.
Please always use tracing for printing logs and add a message for some context.
|
sorry, can you unassign me? i'm a bit busy and i'm not sure if i can make this. |
Sure thing. I'll leave this open as a starting point for someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can try to refund even if it is no longer possible. We will show plain text error rather than ugly JSON error, see #674 for more info.
Fixes #683