revert: bank change module to account change #20427
Conversation
WalkthroughWalkthroughThe recent changes involve minor formatting adjustments and the removal of specific lines of code in test functions. The logic and control flow of the code remain unaffected. Notably, a test function related to coin sending was removed, and minor import reordering was done for better organization. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
tests/e2e/accounts/base_account_test.go (1)
Line range hint
63-63: Removal of error handling infundAccountmay lead to uncaught errors during tests.Consider restoring the error check or ensuring that error handling is managed upstream to maintain robustness in testing.
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- store/rootmulti/store.go (3 hunks)
- tests/e2e/accounts/base_account_test.go (1 hunks)
- testutil/testdata/grpc_query.go (1 hunks)
- x/bank/keeper/keeper_test.go (1 hunks)
Files skipped from review due to trivial changes (3)
- store/rootmulti/store.go
- testutil/testdata/grpc_query.go
- x/bank/keeper/keeper_test.go
Additional Context Used
Path-based Instructions (1)
tests/e2e/accounts/base_account_test.go (3)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"
Additional comments not posted (1)
tests/e2e/accounts/base_account_test.go (1)
Line range hint
1-63: The test code conforms to the Uber Golang style guide and appears to cover relevant functionality.However, consider the potential impact of removing error checks on the reliability of your tests.
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
x/bank/keeper/keeper.go (1)
Line range hint
46-46: The logic and error handling in this file are robust and adhere well to the requirements of a banking module in a blockchain context.However, consider using structured logging for better readability and maintenance.
- k.Logger.Error(fmt.Sprintf("Module %q attempted to mint coins %s it doesn't have permission for, error %v", moduleName, amounts, err)) + k.Logger.Error("attempt to mint unauthorized coins", "module", moduleName, "amounts", amounts, "error", err)This change enhances the readability and maintainability of log messages.
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- store/cache/cache.go (1 hunks)
- x/bank/keeper/keeper.go (1 hunks)
Additional Context Used
Path-based Instructions (2)
store/cache/cache.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/bank/keeper/keeper.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
| @@ -43,7 +43,7 @@ type ( | |||
| func NewCommitKVStoreCache(store types.CommitKVStore, size uint) *CommitKVStoreCache { | |||
| cache, err := lru.NewARC(int(size)) | |||
| if err != nil { | |||
| panic(fmt.Errorf("failed to create KVStore cache: %s", err)) | |||
| panic(fmt.Errorf("failed to create KVStore cache: %w", err)) | |||
There was a problem hiding this comment.
Consider replacing panic with error handling to improve robustness.
- panic(fmt.Errorf("failed to create KVStore cache: %w", err))
+ return nil, fmt.Errorf("failed to create KVStore cache: %w", err)This change requires updating the function signature to return an error and handling this error in all calling functions.
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
x/bank/CHANGELOG.md (2)
Line range hint
35-35: Correct verb agreement in the description.- methods now returns an error instead of panicking if any module accounts does not exist or unauthorized. + methods now return an error instead of panicking if any module accounts do not exist or are unauthorized.
Line range hint
40-43: Fix unordered list indentation.- * Changed `NewInput`, `NewOutput`, `NewQueryBalanceRequest`, `NewQueryAllBalancesRequest`, `NewQuerySpendableBalancesRequest` to accept a string instead of an `AccAddress`. - * Added an address codec as an argument to `NewSendAuthorization`. - * Added an address codec as an argument to `SanitizeGenesisBalances` which also returns an error. - * (simulation) `RandomGenesisBalances` also returns an error. + * Changed `NewInput`, `NewOutput`, `NewQueryBalanceRequest`, `NewQueryAllBalancesRequest`, `NewQuerySpendableBalancesRequest` to accept a string instead of an `AccAddress`. + * Added an address codec as an argument to `NewSendAuthorization`. + * Added an address codec as an argument to `SanitizeGenesisBalances` which also returns an error. + * (simulation) `RandomGenesisBalances` also returns an error.
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- x/bank/CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (2)
x/bank/CHANGELOG.md (2)
Near line 35: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...MintCoinsandBurnCoinsmethods now returns an error instead of panicking if any mo...
Near line 35: The verb form ‘does’ does not seem to match the subject ‘accounts’.
Context: ...ead of panicking if any module accounts does not exist or unauthorized. ### API Bre...
Path-based Instructions (1)
x/bank/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
* main: (95 commits) fix(x/accounts): check for overflows in multisig weights and votes (#20384) docs(x/account/auth): Improve error handling and comments in fee.go (#20426) docs: fix some markdown syntax (#20432) revert: bank change module to account change (#20427) fix: nil pointer panic when store don't exists in historical version (#20425) fix(store/v2): Remove should not error on miss (#20423) chore: upstream more changes from v2 (#20387) docs(x/auth/ante): fixed typo in TxWithTimeoutHeight interface name (#20418) fix: avoid default sendenabled for module accounts (#20419) docs(x/auth): fixed typo in command example for multisign transaction (#20417) build(deps): Bump bufbuild/buf-setup-action from 1.31.0 to 1.32.0 (#20413) build(deps): Bump github.com/hashicorp/go-plugin from 1.6.0 to 1.6.1 in /store (#20414) feat(x/accounts): Add schema caching feature and corresponding test case (#20055) refactor(runtime/v2): remove dependency on sdk (#20389) refactor!: turn MsgsV2 into ReflectMessages to make it less confusing (#19839) docs: Enhanced the ParsePagination method documentation (#20385) refactor(runtime,core): split router service (#20401) chore: fix spelling errors (#20400) docs: Documented error handling in OfferSnapshot method (#20380) build(deps): Bump google.golang.org/grpc from 1.63.2 to 1.64.0 (#20390) ...
Description
this pr reverts an issue with bank that was deemed as not an issue. We tried to make it work but the state machine code is treated as sudo so preventing this could lead to other issues since the limitation of the state machine is different than that of a user
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
Refactor
NewCommitKVStoreCachefunction for better clarity.Tests
fundAccountfunction within the account tests.SendCoinsFromModuleToAccountfunction.