Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin dependencies #13628

Closed
wants to merge 1 commit into from
Closed

ci: Pin dependencies #13628

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/cache action pinDigest -> 0c45773
actions/checkout action pinDigest -> 0ad4b8f
actions/download-artifact action pinDigest -> 65a9edc
actions/labeler action pinDigest -> 8558fd7
actions/upload-artifact action pinDigest -> 6546280
fsfe/reuse-action action pinDigest -> a46482c
gaurav-nelson/github-action-markdown-link-check action pinDigest -> 5c5dfc0
github/codeql-action action pinDigest -> b7cec75
rojopolis/spellcheck-github-actions action pinDigest -> dbd2f1d

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions github-actions bot added the CI Continuous Integration label May 13, 2024
@renovate renovate bot force-pushed the renovate/pin-dependencies branch from 5c570f7 to ffbf4d2 Compare May 14, 2024 15:26
@renovate renovate bot changed the title chore(deps): pin dependencies ci: Pin dependencies May 14, 2024
Copy link
Contributor

@cmeister2 cmeister2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are consistent and as expected

@cmeister2 cmeister2 requested a review from bagder May 14, 2024 16:05
@bagder
Copy link
Member

bagder commented May 14, 2024

I can't comment/review, I don't know if pinning is to prefer to plain versions.

@cmeister2
Copy link
Contributor

I can't comment/review, I don't know if pinning is to prefer to plain versions.

My understanding is that pinning dependencies is preferred for OpenSSF, which I believe curl is signed up for. It's also better to pin to a hash rather than a tag because tags can be changed on Git.

I don't think it's adding much security but I think it's a best practice that doesn't add much, if any, friction with its use.

@bagder
Copy link
Member

bagder commented May 15, 2024

It's also better to pin to a hash rather than a tag because tags can be changed on Git.

... and we automatically adapt to the new one by advancing the pin? Or what kind of extra checks are done when the pin is updated?

How often is this changing, do we know? Does it risk becoming a nuisance?

@bagder
Copy link
Member

bagder commented May 15, 2024

"actions/checkout" is pinned to two different hashes which looks incorrect

@cmeister2
Copy link
Contributor

... and we automatically adapt to the new one by advancing the pin? Or what kind of extra checks are done when the pin is updated?

How often is this changing, do we know? Does it risk becoming a nuisance?

Yes, this auto-advances by advancing the pin. It's not particularly spammy - given we've had this set up on curl-fuzzer for quite a while now and it's raised a handful of updates.

@cmeister2
Copy link
Contributor

"actions/checkout" is pinned to two different hashes which looks incorrect

One is v2 and one is v4 - the update here is being handled by #13632

@bagder
Copy link
Member

bagder commented May 15, 2024

One is v2 and one is v4

So how does it know it is a pinned version of v2 and v4? Is the added comment in the yaml how it knows?

handled by #13632

can't we just merge that PR into this to reduce clutter?

@cmeister2
Copy link
Contributor

One is v2 and one is v4

So how does it know it is a pinned version of v2 and v4? Is the added comment in the yaml how it knows?

I believe so.

handled by #13632

can't we just merge that PR into this to reduce clutter?

I don't think so. Once every instance of the dependency is on the same version then it becomes much less of a clutter problem.

@renovate renovate bot force-pushed the renovate/pin-dependencies branch from ffbf4d2 to f33b044 Compare May 15, 2024 09:39
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this. If it causes too much churn or nuisance we can reconsider later.

@bagder bagder closed this in 7398037 May 15, 2024
@bagder bagder deleted the renovate/pin-dependencies branch May 15, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

None yet

2 participants