-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: set semantic type as CI and include digests as CI operations #13644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the little nit, this looks good
Fix pushed, will merge after checks complete. |
usually in a pr you would squash your incremental work together into one commit, unless they are truly separate, and then rebase before landing. you can judge whether that is the case here. your commit will need an explanation and a reference most of the time. references have a separate blank line and then |
f032990
to
48f2413
Compare
I've rebased the nit comment. I don't think there are any URLs to reference here. If I'm doing pushes wrong I'm happy to let someone with a bit more experience handle the merge here. |
The |
Ah ok - I didn't have a corresponding issue created for this work. |
It should say |
Replace "chore" with "ci" for renovate's semantic type, and include digests with "pin" and "pinDigest" as ci operations. Closes #13644
WolfSSL/WolfSSH use a different versioning scheme; stable builds end with `-stable`. Renovate requires some extra configuration to extract the version from these types of tags. Closes #13644
48f2413
to
bfb803f
Compare
WolfSSL/WolfSSH use a different versioning scheme; stable builds end with `-stable`. Renovate requires some extra configuration to extract the version from these types of tags. Closes #13644
Hopefully removing the last of the "chores" from Renovate.