Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📧 feat: email verification #2344

Merged
merged 39 commits into from
Jun 7, 2024
Merged

📧 feat: email verification #2344

merged 39 commits into from
Jun 7, 2024

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Apr 6, 2024

Summary

added email verification for secure sign-ups 💪

(forgot to change the branch name oops)

Change Type

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Testing

Email tested with gmail SMTP

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.
  • New documents have been locally validated with mkdocs

@berry-13 berry-13 linked an issue Apr 6, 2024 that may be closed by this pull request
1 task
@berry-13 berry-13 marked this pull request as ready for review April 7, 2024 00:01
@Kevin-free
Copy link

@berry-13 Thank you for your contribution! I merged this PR. After registration, the backend often shows error: [sendEmail] connect ETIMEDOUT 108.xxx.xxx.108:465 (occasionally it can be sent successfully, it may be a network problem here)

But even if I receive the verification email, when I click the link "http://localhost:3080/verify?token=xxx&userId=xxx", it shows "Unexpected Application Error!
404 Not Found". What should I do?

@danny-avila
Copy link
Owner

some technical debt with this PR: unverified users can potentially remain unverified forever. the solution would be to utilize createNewUser with a TTL expiry option. Going to address this before merging

@danny-avila danny-avila linked an issue Jun 7, 2024 that may be closed by this pull request
1 task
@danny-avila danny-avila merged commit ee673d6 into main Jun 7, 2024
4 checks passed
@danny-avila danny-avila deleted the proxy-all-endpoints branch June 7, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Avatar with OIDC not persistent Enhancement: Verify email address on registration
3 participants