-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rule set to detekt marketplace.js #7299
New rule set to detekt marketplace.js #7299
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7299 +/- ##
=========================================
Coverage 84.31% 84.31%
Complexity 4149 4149
=========================================
Files 573 573
Lines 11888 11888
Branches 2458 2458
=========================================
Hits 10023 10023
Misses 613 613
Partials 1252 1252 ☔ View full report in Codecov by Sentry. |
8dd6613
to
a2beeec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding your rule set to the marketplace!
website/src/data/marketplace.js
Outdated
@@ -229,6 +229,17 @@ export const extensions = [ | |||
], | |||
usesTypeResolution: true, | |||
}, | |||
{ | |||
title: "Kiolk's Detekt Rules", | |||
description: "This set contains rule that helps to improve readability and to keep single convention in the whole project.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: "This set contains rule that helps to improve readability and to keep single convention in the whole project.", | |
description: "This set contains rules that help to improve readability and to keep a single project-wide convention.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this description is a bit too generic. Can we describe what your rule is doing instead here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated and added addition description.
website/src/data/marketplace.js
Outdated
@@ -229,6 +229,17 @@ export const extensions = [ | |||
], | |||
usesTypeResolution: true, | |||
}, | |||
{ | |||
title: "Kiolk's Detekt Rules", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this UseInvokeForOperator
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
a2beeec
to
309b1f2
Compare
2fe1223
to
22bf1d0
Compare
22bf1d0
to
755bedd
Compare
This pull request contain information about new rule set that I want to add to marketplace page. General information about set you can find in GitHub repository. In current moment it contains only one rule, I will add more in the future.