-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KtExpression.isUnitExpression() #7311
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7311 +/- ##
=========================================
Coverage 84.78% 84.78%
Complexity 3993 3993
=========================================
Files 576 575 -1
Lines 12021 12015 -6
Branches 2478 2476 -2
=========================================
- Hits 10192 10187 -5
Misses 598 598
+ Partials 1231 1230 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StandardNames.FqNames.unit.shortName().asString()
was so overkill for just "Unit"
! 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
505224d
to
f10ab28
Compare
This function is a bit overengineered and it's simple to refactor to remove its usage.