Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpor] clean commit message #1646

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[mpor] clean commit message #1646

wants to merge 11 commits into from

Conversation

Anthonysdu
Copy link
Collaborator

No description provided.

@fbrausse
Copy link
Member

fbrausse commented Feb 6, 2024

What is this PR doing? There are no code changes. :)

@Anthonysdu
Copy link
Collaborator Author

What is this PR doing? There are no code changes. :)

This Just rename the commit messsages in this PR:#1633

@fbrausse
Copy link
Member

fbrausse commented Feb 6, 2024

Don't understand, sorry. You can't rename what's already been committed to the master branch.

@Anthonysdu
Copy link
Collaborator Author

Don't understand, sorry. You can't rename what's already been committed to the master branch.

Oh, since the commits massages were too short ("add reg", "move to disabled" etc.), I think it maybe better to add some brackets to the beginning to normalize them

@fbrausse
Copy link
Member

@Anthonysdu I understand you want to change the commit messages, but they've already been committed to the master branch, i.e., they are part of the history. Nothing will happen when we merge this branch (it will be rebased, which will exclude all commits applied already - disregarding the commit message) and there'll be nothing left. Can we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants