Fix recursive structs in templates #1782 #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intrigus-lgtm
force-pushed
the
fix-recursive-structs-in-templates
branch
2 times, most recently
from
83a66b1
to
439875a
Compare
mikhailramalho
requested changes
Apr 15, 2024
| gh-1782.cc | ||
|
|
||
| ^ERROR: main symbol `main' not found | ||
| ^ERROR: CONVERSION ERROR |
There was a problem hiding this comment.
Just add an empty main here and make the test pass.
| @@ -359,6 +366,10 @@ bool clang_c_convertert::get_struct_union_class(const clang::RecordDecl &rd) | |||
| * or it's already a complete struct or union in the context. */ | |||
| if (!sym->type.incomplete()) | |||
| return false; | |||
|
|
|||
| /* If we're only forward declaring, we don't need to complete the type */ | |||
| if (only_forward_declare) | |||
There was a problem hiding this comment.
Can't you just call isThisDeclarationADefinition() here?
| @@ -1210,7 +1228,8 @@ template <typename SpecializationDecl> | |||
| bool clang_cpp_convertert::get_template_decl_specialization( | |||
| const SpecializationDecl *D, | |||
| bool DumpExplicitInst, | |||
| exprt &new_expr) | |||
| exprt &new_expr, | |||
| bool OnlyForwardDeclare) | |||
There was a problem hiding this comment.
Or maybe check D->isThisDeclarationADefinition() here?
intrigus-lgtm
force-pushed
the
fix-recursive-structs-in-templates
branch
from
439875a
to
5166f78
Compare
Apologies, I should have opened this as a draft instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Add explanation.