-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-frontend] Operational model for int.from_bytes() #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brcfarias
commented
May 18, 2024
•
edited
edited
- Adding support for int.from_bytes
- Given that the frontend still doesn't support strings, the AST is being manipulated to replace the "byteorder" parameter with a boolean "is_bigendian".
- "bytes" array data is being encoded in base64 because json.dump() adds escape characters for non-printable ASCII characters. Additionally, in some cases it was not possible to diferentiate text from numerical values (e.g. "AAFF"). Now, "bytes" data is encoded in base64, and we store the corresponding int value after decoding in python_converter.
- Adding new "consensus" type mappings.
…on during json dumping
…orted) string to boolean
brcfarias
force-pushed
the
python-frontend
branch
from
May 18, 2024 11:57
dbfc737
to
10c2f97
Compare
lucasccordeiro
requested changes
May 19, 2024
lucasccordeiro
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR, @brcfarias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.