Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject.toml to install build dependencies. #3611

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SamWilsn
Copy link

For whatever reason, installing using pip within pip doesn't work in pypy. Presumably because of something to do with build isolation. This commit adds a pyproject.toml with the required packages, so that the dependencies are installed before entering setup.py.

For whatever reason, installing using pip within pip doesn't work in
pypy. Presumably because of something to do with build isolation. This
commit adds a `pyproject.toml` with the required packages, so that the
dependencies are installed before entering `setup.py`.
@megtog
Copy link

megtog commented May 7, 2024

Saw this comment at #1596 (comment)

pyproject.toml

Agree it's neat, but hesitant to introduce extra files into global scope of the specs repo. It's really just the regular setuptools setup, with some extra distutils commands. No exotic build system to reference.

maybe outdated maybe relevant 😀

@SamWilsn
Copy link
Author

SamWilsn commented May 7, 2024

Unfortunately there is an exotic build system; it just happens to fit entirely in setup.py 🤣

@megtog
Copy link

megtog commented May 7, 2024

My knowledge of Python packaging is quite limited. However, I would like to share my experience.

It seems with this pyprojet.toml change, one can import eth2spec at root directory (no need to cd ./tests/core/pyspec anymore, I saw people struggle with this when starting hacking on consensus-specs before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants