Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/build: fix crash in MustRunCommandWithOutput #28709

Merged
merged 1 commit into from
Dec 20, 2023
Merged

internal/build: fix crash in MustRunCommandWithOutput #28709

merged 1 commit into from
Dec 20, 2023

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Dec 19, 2023 •
edited

Fixes the crash below, which happens because the done channel was not initialized.

Waiting for command "build/cache/golangci-lint-1.51.1-linux-amd64/golangci-lint"
panic: close of nil channel
goroutine 1 [running]:
github.com/ethereum/go-ethereum/internal/build.MustRunCommandWithOutput({0xc0002d1500, 0x3a}, {0xc000296060, 0x4, 0x6})
	/home/appveyor/projects/go-ethereum/internal/build/util.go:87 +0xac
main.doLint({0xc0000ae000, 0x0, 0x0})
	/home/appveyor/projects/go-ethereum/build/ci.go:369 +0x237
main.main()
	/home/appveyor/projects/go-ethereum/build/ci.go:167 +0x1b3

@holiman holiman merged commit 7124057 into ethereum:master Dec 20, 2023
3 checks passed
@holiman holiman modified the milestones: 1.13.7, 1.13.8 Dec 20, 2023
Doozers pushed a commit to kilnfi/pgeth that referenced this pull request Dec 22, 2023
@fjl @Doozers
internal/build: fix crash in MustRunCommandWithOutput (ethereum#28709)
35fcea1
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@fjl @Dergarcon
internal/build: fix crash in MustRunCommandWithOutput (ethereum#28709)
2288144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fjl @rjl493456442 @holiman